Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator does not render valid adaptive card in an activity #2154

Closed
chrimc62 opened this issue May 29, 2020 · 9 comments
Closed

Emulator does not render valid adaptive card in an activity #2154

chrimc62 opened this issue May 29, 2020 · 9 comments
Labels
Bug Your classic code defect

Comments

@chrimc62
Copy link
Contributor

chrimc62 commented May 29, 2020

Version of emulator: 4.9.1

The below activity has a valid adaptive card that renders properly in adaptivecards.io. In emulator it looks like the below. It seems related to having a curly bracest in the string value. If I change it to obj= and remove the trailing curly brace it works fine.

In emulator (wrong):
image

In adaptive cards designer (right):
image

Activity:

{
    "type": "message",
    "attachments": [
        {
            "contentType": "application/vnd.microsoft.card.adaptive",
            "content": {
                "type": "AdaptiveCard",
                "version": "1.0",
                "body": [
                    {
                        "type": "TextBlock",
                        "text": "simple",
                        "size": "large"
                    },
                    {
                        "type": "FactSet",
                        "facts": [
                            {
                                "title": "due",
                                "value": "{timex: [2020-06-01], type: date}"
                            }
                        ]
                    }
                ],
                "$schema": "http://adaptivecards.io/schemas/adaptive-card.json"
            }
        }
    ]
}
@tonyanziano
Copy link
Contributor

We should test this in Web Chat.

@tonyanziano tonyanziano added the Bug Your classic code defect label May 29, 2020
@stevkan
Copy link
Collaborator

stevkan commented Jun 1, 2020

Possibly related to Web Chat bug #3165

@stevkan stevkan added Bot Services equired for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. and removed Bot Services equired for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Jun 1, 2020
@chrimc62
Copy link
Contributor Author

chrimc62 commented Sep 4, 2020

This is still an issue. This:
image
Renders as this:
image

@tonyanziano
Copy link
Contributor

I just tested this with the latest Web Chat and the bug is still present in 4.10.0.

The issue (microsoft/BotFramework-WebChat#3165) has been labeled for R11 and can be tracked there.

@chrimc62
Copy link
Contributor Author

This was not fixed in R11 or R12. Is it ever going to be fixed?

@tonyanziano
Copy link
Contributor

@chrimc62 this is a Web Chat bug so it will be present in Emulator until it is fixed in Web Chat. If you look at microsoft/BotFramework-WebChat#3165 you can see that it was moved into the R13 milestone last week.

@corinagum
Copy link
Contributor

In progress now - sorry @chrimc62 for the wait. Low on manpower haha.

@amazingYolk
Copy link

Still not fixed in version 4.14.1 of emulator, how's it going?

@amazingYolk
Copy link

Still not fixed in version 4.14.1 of emulator, how's it going?

image

@OEvgeny OEvgeny closed this as completed Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Your classic code defect
Projects
None yet
Development

No branches or pull requests

6 participants