Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt entity misleading error message #8670

Open
2 of 8 tasks
MatteoMeil opened this issue Sep 16, 2021 · 2 comments
Open
2 of 8 tasks

Prebuilt entity misleading error message #8670

MatteoMeil opened this issue Sep 16, 2021 · 2 comments
Labels
Backlog Backlog items - not in current milestone Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport Team: Platform Type: Bug Something isn't working

Comments

@MatteoMeil
Copy link
Contributor

Describe the bug

When using some prebuilt entities not available in selected locale (culture), instead of throwing error or outputting a warning it says a completely different message. E.g.: this error message is outputted with it-it using geographyV2

Luis build failed: [ERROR] line 20:0 - line 20:1: Invalid child entity definition found. No definition found for "geographyV2" in child entity definition "- @ ml MLSubEntity usesFeature geographyV2". Features must be defined before they can be added to a child.

Related issues:

Version

Version: 2.1.1
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create a new Bot
  2. Change locale to something different from en-us
  3. Create a new Intent recognizer that uses LUIS
  4. Insert some prebuilt entity not available for current locale
  5. Try to build the bot

Expected behavior

It should tell the user that the prebuilt entity is not available.

Screenshots

Not applicable

Additional context

This error is due to the fact that Builder is constructed in this line passing a log function.
This way, bf-cli outputs a warning (see here) that's not captured by Composer.

Referenced issues on bf-cli already address this problem

@MatteoMeil MatteoMeil added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Sep 16, 2021
@dmvtech dmvtech added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Sep 17, 2021
@tonyanziano tonyanziano added Team: Runtime & Publishing Backlog Backlog items - not in current milestone Team: Platform and removed Needs-triage A new issue that require triage Team: Runtime & Publishing labels Sep 21, 2021
@compulim
Copy link

@tonyanziano I think this is a solid bug we want to take, right?

@tonyanziano
Copy link
Contributor

@compulim I think it is an issue that should be fixed, however I am unclear on how we should prioritize it given the PVA work items.

@srinaath / @cwhitten any comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog Backlog items - not in current milestone Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. ExemptFromDailyDRIReport Team: Platform Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants