Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent naming for .NET Core/Kestrel server settings in launchsettings.json #3364

Closed
dmvtech opened this issue Jul 6, 2021 · 3 comments · Fixed by #3401
Closed

Use consistent naming for .NET Core/Kestrel server settings in launchsettings.json #3364

dmvtech opened this issue Jul 6, 2021 · 3 comments · Fixed by #3401
Assignees

Comments

@dmvtech
Copy link
Collaborator

dmvtech commented Jul 6, 2021

Sample information

All .NET Core samples here.

Describe the bug

For the dotnet core samples, the names for the core/Kestrel server are all over the place. Some match the actual project name, some are abbreviated so far that they do not make sense and many are completely wrong.

The launch settings for IIS Express are consistent. We should do the same for Core/Kestrel.

For example, we have something like:
image

    "DispatcherBot": {
      "commandName": "Project",
      "launchBrowser": true,
      "environmentVariables": {
        "ASPNETCORE_ENVIRONMENT": "Development"
      },
      "applicationUrl": "http://localhost:3978/"
    }

We don't need unique names for each sample, since the selected project is enough. Should have consistent and clear name for all samples using Core/Kestrel.

I don't know what name might be best to use, but some options:

  • .NET Core <--my vote
  • Kestrel
  • Core (Kestrel)
  • .NET Core (Kestrel)

And then would be something like:

    ".NET Core": {
      "commandName": "Project",
      "launchBrowser": true,
      "environmentVariables": {
        "ASPNETCORE_ENVIRONMENT": "Development"
      },
      "applicationUrl": "http://localhost:3978/"
    }

Additional context

https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-5.0

@dmvtech dmvtech added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. and removed bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jul 6, 2021
@dmvtech dmvtech self-assigned this Jul 6, 2021
@dmvtech
Copy link
Collaborator Author

dmvtech commented Jul 6, 2021

@cleemullins @EricDahlvang @mrivera-ms Any thoughts on which name to use?

@EricDahlvang
Copy link
Member

Great idea! simple consistency trumps unnecessary complexity :)

I prefer ".NET Core", since I'm not even sure exactly what 'kestrel' is.

@mrivera-ms
Copy link
Contributor

If we want to keep consistency with .NET Core apps, by default the Kestrel end points are created using the project name. Either way works. +1 on consistency across all samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants