Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split CycleData into StepData #24

Open
fingertap opened this issue Dec 4, 2023 · 1 comment
Open

Split CycleData into StepData #24

fingertap opened this issue Dec 4, 2023 · 1 comment
Assignees

Comments

@fingertap
Copy link
Collaborator

Currently the BatteryData is split into multiple CycleData, which typically consists of a charging and discharging process. However, in real-world battery tests, the cycles are further split into steps, supporting more features such as different rates, resting, interleaving charging and discharging with the same cycle, etc.

Another advantage of using StageData is that it makes the process that splits the raw electric signals and organize into BatteryData object much easier, as we can operate on the stage level for cycle split. This feature should also help us better address the open issues #14 #15 for incorporating more data.

I will make a PR for this.

@fingertap fingertap self-assigned this Dec 4, 2023
@fingertap
Copy link
Collaborator Author

This also renders the CyclingProtocol useless, as after this modification, a CycleData is consist of several StageData, which should be convenient to infer the protocol. Specifications can be added to CycleData's meta data as strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant