Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airlock - Handle malware scanning failed scans #2274

Closed
2 tasks
eladiw opened this issue Jul 16, 2022 · 3 comments · Fixed by #2666
Closed
2 tasks

Airlock - Handle malware scanning failed scans #2274

eladiw opened this issue Jul 16, 2022 · 3 comments · Fixed by #2666
Assignees
Labels
airlock story Stories are the smallest unit of work to be done for a project.

Comments

@eladiw
Copy link
Contributor

eladiw commented Jul 16, 2022

Description

As a TRE Developer
I want to be handle malware failed scans and move the request to failed
So that the researcher knows the request failed

Acceptance criteria

  • Failed to scan for any reason should be catched by the airlock processor (e.g. password protected file / encrypted)
  • move the request to failed state
@eladiw eladiw added story Stories are the smallest unit of work to be done for a project. airlock labels Jul 16, 2022
@tanya-borisova
Copy link
Contributor

The issue here is how to know there was a failed scan. E.g. password protected zip might cause a problem

@yuvalyaron
Copy link
Collaborator

#2395 might be useful as a reference

@tamirkamara tamirkamara added this to the Release 0.5 milestone Aug 3, 2022
@yuvalyaron
Copy link
Collaborator

yuvalyaron commented Aug 7, 2022

Password protected zip files result in "blocked by scanner" status - we should add the output of the the scanner to the "errorMessage" field that we have in AirlockRequest (we should rename errorMessage to statusMessage to make it more generic).

Files that are too big (>2GiB) are currently ignored by the scanner, and result in the request being stuck on "submit" - this should be addressed by the malware scanner team, as we currently don't have any indication that the request is invalid.

@yuvalyaron yuvalyaron self-assigned this Sep 14, 2022
@tamirkamara tamirkamara removed the blocked Cannot progress at present label Sep 14, 2022
Repository owner moved this from Backlog to Done in AzureTRE - Crew Rock Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airlock story Stories are the smallest unit of work to be done for a project.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants