Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteAsJsonAsync alwasy return http status code 200 #498

Open
catcherwong opened this issue Jul 11, 2023 · 1 comment · May be fixed by #499
Open

WriteAsJsonAsync alwasy return http status code 200 #498

catcherwong opened this issue Jul 11, 2023 · 1 comment · May be fixed by #499

Comments

@catcherwong
Copy link
Contributor

AzUrlShortener/src/Cloud5mins.ShortenerTools.Functions/Functions/UrlUpdate.cs

Lines 114 to 116 in a1ec3ee

var badRequest = req.CreateResponse(HttpStatusCode.BadRequest);
await badRequest.WriteAsJsonAsync(new { ex.Message });
return badRequest;

HttpStatusCode.BadRequest does not take effect after calling WriteAsJsonAsync.
@catcherwong
Copy link
Contributor Author

Following https://github.com/Azure/azure-functions-dotnet-worker/blob/ebf8e680f6c84adbecb2a6e6cb77e80cf8b0a17f/samples/CustomMiddleware/ExceptionHandlingMiddleware.cs#L42-L46 , we should pass the status code in WriteAsJsonAsync method.

catcherwong added a commit to catcherwong/AzUrlShortener that referenced this issue Jul 11, 2023
@catcherwong
fix http status code (microsoft#498)
a0c1550 
Signed-off-by: catcherwong <[email protected]>
@catcherwong catcherwong linked a pull request Jul 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix http status code (#498) catcherwong/AzUrlShortener
1 participant
@catcherwong