Disable module metadata for all release artifacts (#3836)

microsoft · Aug 12, 2024 · ec143c4 · ec143c4
1 parent 56b59b8
commit ec143c4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/agent/agent/build.gradle.kts b/agent/agent/build.gradle.kts
@@ -165,13 +165,6 @@ tasks {
   named("generateLicenseReport").configure {
     dependsOn(cleanLicenses)
   }
-
-  // Because we reconfigure publishing to only include the shadow jar, the Gradle metadata is not correct.
-  // Since we are fully bundled and have no dependencies, Gradle metadata wouldn't provide any advantage over
-  // the POM anyways so in practice we shouldn't be losing anything.
-  withType<GenerateModuleMetadata>().configureEach {
-    enabled = false
-  }
 }
 
 // Don't publish non-shadowed jar (shadowJar is in shadowRuntimeElements)

diff --git a/agent/runtime-attach/build.gradle.kts b/agent/runtime-attach/build.gradle.kts
@@ -24,9 +24,4 @@ tasks {
       attributes("Automatic-Module-Name" to "com.microsoft.applicationinsights.attach")
     }
   }
-
-  // disabling the publication of Gradle Module Metadata
-  withType<GenerateModuleMetadata>().configureEach {
-    enabled = false
-  }
 }
diff --git a/buildSrc/src/main/kotlin/ai.java-conventions.gradle.kts b/buildSrc/src/main/kotlin/ai.java-conventions.gradle.kts
@@ -89,6 +89,14 @@ tasks {
     isPreserveFileTimestamps = false
     isReproducibleFileOrder = true
   }
+
+  // disabling the publication of Gradle Module Metadata
+  // Because we reconfigure publishing to only include the shadow jar, the Gradle metadata is not correct.
+  // Since we are fully bundled and have no dependencies, Gradle metadata wouldn't provide any advantage over
+  // the POM anyways so in practice we shouldn't be losing anything.
+  withType<GenerateModuleMetadata>().configureEach {
+    enabled = false
+  }
 }
 
 normalization {