Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect role is defined for controls present on adaptive cards as list item instead of button. #7809

Closed
baton17 opened this issue Sep 6, 2022 · 1 comment

Comments

@baton17
Copy link
Contributor

baton17 commented Sep 6, 2022

Target Platforms

NodeJS

SDK Version

2.10.0

Application Name

Microsoft Teams

Problem Description

Repro Steps:

  1. Open Teams application
  2. Navigate to Teams channel where card is present.

image

  1. Now navigate to "SSO button" , OAuth Button" , "Loop SSO" controls.
  2. Observe that the incorrect role is defined for controls above controls as list item.

Actual Results:
Incorrect role is defined for controls present on adaptive cards as list item instead of button. Screen reader is announcing it as "Loop SSO 3 of 5" for the third button with title "Loop SSO"

Expected Results:
Correct role should be defined as button for the controls present on Adaptive card.

User Impact:
Screen reader user will face difficulties while accessing the control if incorrect role is defined for the control they might confused about the controls.

Screenshots

No response

Card JSON

{
        "type": "AdaptiveCard",
        "body": [
            {
                "color": null,
                "horizontalAlignment": null,
                "isSubtle": false,
                "maxLines": 0,
                "size": "medium",
                "text": "Happy Testing",
                "weight": "bolder",
                "wrap": false,
                "separator": false,
                "type": "TextBlock"
            },
            {
                "color": null,
                "horizontalAlignment": null,
                "isSubtle": false,
                "maxLines": 0,
                "size": "medium",
                "text": "Refreshed Card",
                "weight": "bolder",
                "wrap": false,
                "separator": false,
                "type": "TextBlock"
            },
            {
                "actions": [
                    {
                        "verb": "initiateSSO",
                        "title": "SSO Button",
                        "type": "Action.Execute"
                    },
                    {
                        "verb": "initiateOAuth",
                        "title": "OAuth Button",
                        "type": "Action.Execute"
                    },
                    {
                        "verb": "loopSSO",
                        "title": "Loop SSO",
                        "type": "Action.Execute"
                    },
                    {
                        "verb": "loopOAuth",
                        "title": "Loop OAuth",
                        "type": "Action.Execute"
                    },
                    {
                        "verb": "latency",
                        "title": "Latency",
                        "type": "Action.Execute"
                    },
                    {
                        "verb": "TestPreConditionFailed",
                        "title": "Test PreCondition Failed SSO",
                        "type": "Action.Execute"
                    },
                    {
                        "verb": "TestPreConditionFailedWithoutSignIn",
                        "title": "Test PreCondition Failed SSO without SignIn",
                        "type": "Action.Execute"
                    },
                    {
                        "title": "Action Submit Button",
                        "type": "Action.Submit"
                    }
                ],
                "separator": false,
                "type": "ActionSet"
            },
            {
                "color": null,
                "horizontalAlignment": null,
                "isSubtle": false,
                "maxLines": 0,
                "size": "medium",
                "text": "SSO success",
                "weight": "bolder",
                "wrap": false,
                "separator": false,
                "type": "TextBlock"
            }
        ],
        "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
        "version": "1.2",
        "refresh": {
            "action": {
                "verb": "basicRefresh",
                "title": "RefreshTitle",
                "type": "Action.Execute"
            }
        }
    }

Sample Code Language

No response

Sample Code

No response

@baton17 baton17 changed the title [Teams ]: Incorrect role is defined for controls present on adaptive cards as list item instead of button. [Teams]: Incorrect role is defined for controls present on adaptive cards as list item instead of button. Sep 6, 2022
@baton17 baton17 changed the title [Teams]: Incorrect role is defined for controls present on adaptive cards as list item instead of button. Incorrect role is defined for controls present on adaptive cards as list item instead of button. Sep 6, 2022
@paulcam206
Copy link
Member

This should be fixed with #6763, but a 2.x release hasn't been made with this yet. I believe we're on track to do this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants