Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS][Rendering] ActionSet rendered DOM element shouldn't have the "menubar" role #6156

Closed
dclaux opened this issue Aug 2, 2021 · 2 comments

Comments

@dclaux
Copy link
Member

dclaux commented Aug 2, 2021

Target Platform

  • NodeJS

Problem Description

A card with an ActionSet that contains at least one Action.OpenUrl will not pass a fast-pass accessibility insight test because the DOM element generated for the ActionSet is stamped with the "menubar" role. A container with the "menubar" role can only contain children with roles “group”, “menuitemradio”, “menuitem” or “menuitemcheckbox”, however the DOM button generated for an Action.OpenUrl has the "link" role, which is correct.

The role of the DOM element generated for the ActionSet should be either removed or changed to something else (investigation needed). Note that removing the "menubar" role altogether solves the problem and makes the accessibility insight test pass; it may however not be the ideal solution in terms of end user experience.

Version of SDK

Latest

@golddove
Copy link
Member

golddove commented Aug 2, 2021

@dclaux is this a dup of #6019 ?

@dclaux
Copy link
Member Author

dclaux commented Aug 2, 2021

@golddove Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants