Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web][Accessibility] Actions with the OpenUrl onAction should render as an a tag #4947

Closed
felixvanleeuwen opened this issue Oct 21, 2020 · 5 comments
Labels
Area-Accessibility Bugs around feature accessibility Request

Comments

@felixvanleeuwen
Copy link

felixvanleeuwen commented Oct 21, 2020

What platform is your feature request related to? (Delete other platforms).

  • .NET HTML
  • .NET WPF
  • Android
  • iOS
  • JavaScript
  • UWP

Is your feature request related to a problem? Please describe.
A European law has been passed that forces public websites to adhere to a AA accessibility rating.
Using adaptive cards prevents this.
All actions are rendered the same, as buttons.
For blind or poor sighted people who browse the web (using screen readers) this is incredibly confusing.

Describe the solution you'd like
By default, the Action.OpenUrl is rendered as an <a>-tag.
Users who rely on sight don't notice a difference.

Describe alternatives you've considered
Some rendering middleware, but could not find one that exists.

@dclaux
Copy link
Member

dclaux commented Nov 6, 2020

@felixvanleeuwen since version 2.3 of the JS SDK, all OpenUrl actions are rendered with the "aria-role": "link" attribute, which should be enough to satisfy the regulation. Rendering them as an <a> tag is only necessary if the proper aria-role is missing, which isn't the case.

@dclaux
Copy link
Member

dclaux commented Nov 6, 2020

Scrap what I wrote above. While that was true, another accessibility change has been applied on top of it that changes buttons' role to "menuitem".

We're going to have to look into this and determine what the right solution is.

@matthidinger matthidinger added this to the 20.11 milestone Nov 6, 2020
@ghost ghost added the AdaptiveCards v20.11 label Nov 6, 2020
@RebeccaAnne RebeccaAnne added the Area-Accessibility Bugs around feature accessibility label Dec 2, 2020
@RebeccaAnne RebeccaAnne modified the milestones: 20.11-12, 21.01 Dec 2, 2020
@ghost ghost removed the AdaptiveCards v20.11 label Dec 3, 2020
@ghost ghost added the AdaptiveCards v21.01 label Dec 18, 2020
@RebeccaAnne RebeccaAnne modified the milestones: 21.01, Short Term Jan 21, 2021
@ghost ghost removed the AdaptiveCards v21.01 label Jan 22, 2021
@felixvanleeuwen
Copy link
Author

Any news on this?

@RebeccaAnne RebeccaAnne removed this from the Short Term milestone May 6, 2021
@matthijsgg
Copy link

I'm taking over this feature request since OP has left the team. Is there any update on this?

@paulcam206
Copy link
Member

This issue has been fixed in #6763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Request
Projects
None yet
Development

No branches or pull requests

8 participants