-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Id property to all elements and actions #493
Comments
The concept sounds good to me. So this would not be a required property then? |
It will be at the discretion of hosts. Some hosts might want to make the Id property of an action required, some might not. I don't think the Id property of an element would be required at all. |
works for me too. |
@riarenas did we already add this to UWP by chance? |
This is done in UWP for Actions and CardElements. Should this apply to elements that only exist inside specific containers such as choices, facts and columns? |
According to the current schema documentation, column should have an id, but choice and fact should not. Shared model and UWP renderer all reflect that. |
That's how it is in C# as well, since Fact and Choice are not "typed" elements which is where we added the Id property. |
This seems to be done across the board, closing. |
This is documented in main and will go out with the next website deployment. |
Implementation status
Problem
Solution
Add the following property on all element and action types
The text was updated successfully, but these errors were encountered: