-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextBlock add Monospace property #398
Comments
How would you handle the chosen font? |
@mdtauk each platform renderer would either choose a default if possible, otherwise (and probably in addition to) we would add a HostConfig option to allow hosts to specify their monospace font of choice |
Concerns about using markdown (costly to implement, etc), other proposal seems easier. Teams, however, would like to see both options work. Need to flush out proposal more to see which option to go with. |
Closing in favor of #1078 |
Implementation status
Problem
There's no way to display console output, ascii art 😜, etc
Example Comps
Asks
Proposal: Use Markdown
Simply add support for Markdown code blocks?
Spec Changes
Markdown support expands to code blocks (but no syntax highlighting)
Host Config
Add monospaceFontFamily to host config...
Renderer Requirements
Downlevel Impact
Medium - Users see odd ``` but otherwise not a big deal, they still see the content
Proposal: Use TextStyle
Simply add TextStyle to TextBlock with a monospace option? Related to solution of fonts for text: #1078
To achieve a border/background, the author could wrap this in a container with emphasis enabled.
Depending on how we build it, we could also use this to enable inline fonts, similar to the last proposal on inline colors: #1079
Spec Changes
Addition of textStyle property on TextBlock (with values of default and monospace
Host Config
Add monospaceFontFamily to host config...
Renderer Requirements
Downlevel Impact
None - Users see the content, but it simply isn't monospace (same as today)
The text was updated successfully, but these errors were encountered: