Sentiment should be renamed to style

[paulcam206]

Per email thread, the action sentiment property should be renamed to style.

[shalinijoshi19]

@paulcam206 / @andrewleader why is this a specbug? I understand this needs to be changed in code yes? Also do we want to create platform-specific workitems? @RebeccaAnne + @nesalang FYI this rename might be coming to you guys respectively

[andrewleader]

Maybe Paul assigned the SpecBug label thinking that's how we track bugs that are a result of spec bugs? Idk 😵 We have lots of labels 😛

Yes, this needs to be changed in code.

Platform-specific work items sound good to me if that's what you'd like! Up to the dev team :)

[paulcam206]

I added SpecBug because at the time I filed, there was still the outstanding question of whether we allow arbitrary styles. That seems resolved now on the email thread, but it needs to be documented in the spec (#861).

As it stands, the spec still calls for style to be an enum value rather than a string.

[shalinijoshi19]

Awesome! Great find @paulcam206 and thanks a ton @RebeccaAnne for being on top of this including getting the children spun up and assigned! Looks like this should land in 1.2 just fine.

[andrewleader]

The spec seems to be correct, it should be an enum. There's simply the option for hosts to extend support and add different values (which UWP added). That's a host-specific feature. From the authoring side, it still should be an enum for ease of authoring (if they're sending to a host that has a custom value, they'll need to do something different... same as if they're sending to a host that has a custom container style)

[paulcam206]

fair enough! 👍

[dclaux]

As part of #2981 I made the JS implementation extensible.