Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RichTextBlock][Android] Update existing richtextblock implementation to match new specification for 1.2 #2671

Closed
shalinijoshi19 opened this issue Apr 11, 2019 · 2 comments

Comments

@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Apr 11, 2019

To address the length concerns, we’re simplifying the payload
a. Removing the concept of paragraphs, so it’s just a set of inlines
b. Syntax sugar for auto-converting a text string into a basic TextRun
For the wrap/maxLines
a. Remove those properties
For the markdown inside runs
a. Don’t support markdown
For being able to use italics within runs (since no markdown)
a. Possibly add an “italicize” property to TextRun
Changes…

Removed “paragraphs”. Now it directly goes to “inlines”
Syntax sugar for converting a text string into a basic TextRun object (to reduce payload size when you don’t need any special formatting)
Removed “wrap” and “maxLines” properties
Removed markdown support from TextRun
Added “italicize” (name pending) to TextRun so you can italicize text

@shalinijoshi19
Copy link
Member Author

@RebeccaAnne FYI.

@andrewleader andrewleader removed this from the 1904 milestone Apr 12, 2019
@andrewleader andrewleader changed the title [RichTextBlock][Android] Update existing richtextblock implementation to match new specification for 1.2 [Android] inlineAction on text boxes Apr 12, 2019
@shalinijoshi19 shalinijoshi19 changed the title [Android] inlineAction on text boxes [RichTextBlock][Android] Update existing richtextblock implementation to match new specification for 1.2 Apr 12, 2019
@shalinijoshi19
Copy link
Member Author

Closing. This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants