Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RichTextBlock][.NET] Update existing richtextblock implementation to match new specification for 1.2 #2669

Closed
shalinijoshi19 opened this issue Apr 11, 2019 · 1 comment
Assignees
Labels
Area-Renderers Bug Platform-.NET Platform-JavaScript Bugs or features related to the JavaScript renderer

Comments

@shalinijoshi19
Copy link
Member

shalinijoshi19 commented Apr 11, 2019

  1. To address the length concerns, we’re simplifying the payload
    a. Removing the concept of paragraphs, so it’s just a set of inlines
    b. Syntax sugar for auto-converting a text string into a basic TextRun
  2. For the wrap/maxLines
    a. Remove those properties
  3. For the markdown inside runs
    a. Don’t support markdown
  4. For being able to use italics within runs (since no markdown)
    a. Possibly add an “italicize” property to TextRun
  5. For fallback support/extensibility (which markdown doesn’t support)
    a. We’ll add that in 1.3 for text runs (too costly to add now)

Changes…

  1. Removed “paragraphs”. Now it directly goes to “inlines”
  2. Syntax sugar for converting a text string into a basic TextRun object (to reduce payload size when you don’t need any special formatting)
  3. Removed “wrap” and “maxLines” properties
  4. Removed markdown support from TextRun
  5. Added “italicize” (name pending) to TextRun so you can italicize text
@shalinijoshi19
Copy link
Member Author

@RebeccaAnne FYI

@shalinijoshi19 shalinijoshi19 added Platform-.NET Platform-JavaScript Bugs or features related to the JavaScript renderer labels Apr 11, 2019
@andrewleader andrewleader removed this from the 1904 milestone Apr 12, 2019
@andrewleader andrewleader changed the title [RichTextBlock][.NET] Update existing richtextblock implementation to match new specification for 1.2 [.NET] Inline text runs Apr 12, 2019
@andrewleader andrewleader changed the title [.NET] Inline text runs [TS] Inline text runs Apr 12, 2019
@andrewleader andrewleader mentioned this issue Apr 12, 2019
7 tasks
@andrewleader andrewleader changed the title [TS] Inline text runs [.NET] Inline text runs Apr 12, 2019
@andrewleader andrewleader changed the title [.NET] Inline text runs [TS] Inline text runs Apr 12, 2019
@shalinijoshi19 shalinijoshi19 changed the title [TS] Inline text runs [RichTextBlock][.NET] Update existing richtextblock implementation to match new specification for 1.2 Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Renderers Bug Platform-.NET Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Development

No branches or pull requests

4 participants