Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2- Blocking] Update .NET library's AdaptiveContainerStyle property to be nullable #2575

Closed
shalinijoshi19 opened this issue Mar 27, 2019 · 2 comments
Closed

[1.2- Blocking] Update .NET library's AdaptiveContainerStyle property to be nullable #2575

shalinijoshi19 opened this issue Mar 27, 2019 · 2 comments
Assignees
@almedina-ms
Labels
Bug High Priority Platform-.NET
Milestone
1903

Comments

@shalinijoshi19
Copy link
Member

Platform

What platform is your issue or question related to? (Delete other platforms).

  • .NET library

Author or host

None. Feature crew.

Version of SDK

master 1.2

Issue

AdaptiveContainerStyle class should be reverted back to being nullable to match what has shipped (and broken 1.0 already) in version 1.1..
@shalinijoshi19 shalinijoshi19 added this to the 1903 milestone Mar 27, 2019
@shalinijoshi19 shalinijoshi19 pinned this issue Mar 27, 2019
@shalinijoshi19
Copy link
Member Author

@almedina-ms is this compelted?

@almedina-ms almedina-ms mentioned this issue Apr 4, 2019
Merged
@shalinijoshi19 shalinijoshi19 unpinned this issue Apr 4, 2019
@shalinijoshi19
Copy link
Member Author

ALready merged with PR ; I updated the PR description with (Fixes #<>) keyword though after it was committed/merged which may explain why the issue is not closed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almedina-ms almedina-ms

Labels
Bug High Priority Platform-.NET
Projects
None yet
Milestone
1903
Development

No branches or pull requests
2 participants
@shalinijoshi19 @almedina-ms