[Event Request] Codeunit 99000817 "Manu. Print Report".ConvertUsage

[fridrichovsky]

Describe the request

Please add new event

    local procedure ConvertUsage(Usage: Option M1,M2,M3,M4): Enum "Report Selection Usage"
	var
	    ResultReportSelectionUsage: Enum "Report Selection Usage";
    begin
        case Usage of
            Usage::M1:
                exit(ReportSelections.Usage::M1);
            Usage::M2:
                exit(ReportSelections.Usage::M2);
            Usage::M3:
                exit(ReportSelections.Usage::M3);
            Usage::M4:
                exit(ReportSelections.Usage::M4)
            //---------------------------------------------------OnConvertUsageOnUsageElse:BEGIN
            else begin
                OnConvertUsageOnUsageElse(Usage,ResultReportSelectionUsage);
                exit(ResultReportSelectionUsage);
            end;
            //---------------------------------------------------OnConvertUsageOnUsageElse:END
        end;
    end;

    //---------------------------------------------------OnConvertUsageOnUsageElse:BEGIN
    [IntegrationEvent(true, false)]
    local procedure OnConvertUsageOnUsageElse(Usage: Option; var ResultReportSelectionUsage: Enum "Report Selection Usage")
    begin
    end;
    //---------------------------------------------------OnConvertUsageOnUsageElse:END

Additional context

We need option run different usage and different report selection usage.
Internal work item: AB#558147

[nikolakukrika]

The signature of the method needs to be changed too. We should drop the option definition in the code, and replace it with numbers. That would indicate to the code that it can be more options than 4. Option definition in method definition is wrong, we should delete all of these.

[fridrichovsky]

hello @nikolakukrika, I agree, but I do not know if we can suggest this kind of change. If you use integer it is OK for us. Enum with extensible=true can be too.
Thank you

[nikolakukrika]

@fridrichovsky You can ask additional things, the point is to get a good design in place. My comment was more for the team that is processing requests. Defining Options inline is bad. If it is not possible to avoid an option as a parameter in the method signature, then it must not contain any member definitions. The risk is that we are duplicating the definition, it will be hard to keep all the definitions up to date if one of the values changes.