From a7a0cb01bfe1932c4e06c511ba2b310298c9bbd3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marc=20Carr=C3=A9?= Date: Fri, 8 Jun 2018 16:39:01 +0100 Subject: [PATCH] Change port to be 80 by default - `Dockerfile` explicitly overrides `8081` with `80`, so might as well have it as the default: github.com/microservices-demo/catalogue/blob/master/docker/catalogue/Dockerfile#L45-L46 - Should one not realise this override is currently required (but no longer, after this change), issues like microservices-demo/microservices-demo/pull/767 could be experienced. --- cmd/cataloguesvc/main.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/cataloguesvc/main.go b/cmd/cataloguesvc/main.go index 4e04d379..b01eefcc 100644 --- a/cmd/cataloguesvc/main.go +++ b/cmd/cataloguesvc/main.go @@ -43,7 +43,7 @@ func init() { func main() { var ( - port = flag.String("port", "8081", "Port to bind HTTP listener") // TODO(pb): should be -addr, default ":8081" + port = flag.String("port", "80", "Port to bind HTTP listener") // TODO(pb): should be -addr, default ":80" images = flag.String("images", "./images/", "Image path") dsn = flag.String("DSN", "catalogue_user:default_password@tcp(catalogue-db:3306)/socksdb", "Data Source Name: [username[:password]@][protocol[(address)]]/dbname") zip = flag.String("zipkin", os.Getenv("ZIPKIN"), "Zipkin address")