Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Validator doesn't throw UnexpectedTypeException in retry #448

Open
wants to merge 1 commit into
base: 4.9.x
Choose a base branch
from
Open

Fixed: Validator doesn't throw UnexpectedTypeException in retry #448

wants to merge 1 commit into from

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Nov 12, 2024

Fixed #361

dstepanov
dstepanov reviewed Nov 12, 2024
View reviewed changes
validation/src/main/java/io/micronaut/validation/validator/DefaultValidator.java Outdated
try (DefaultConstraintValidatorContext.GroupsValidation ignore = context.withGroupSequence(groupSequence)) {
visitElement(context, publisher, valueArgument, value, canCascade);
}
var context = new DefaultConstraintValidatorContext<>(this, null, publisher, BeanValidationContext.fromGroups(groups));
Copy link
Contributor

@dstepanov dstepanov Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind not making extra changes while fixing something? And doing refactoring, etc., in another PR? Otherwise, it's hard to review what changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, reverted

@dstepanov
Copy link
Contributor

Please target 4.9

@altro3 altro3 force-pushed the validation-on-retry branch from cf698f7 to fe05d6b Compare November 12, 2024 09:21
@altro3 altro3 force-pushed the validation-on-retry branch from fe05d6b to c137af3 Compare November 12, 2024 09:23
@altro3 altro3 changed the base branch from 4.8.x to 4.9.x November 12, 2024 09:23
@altro3
Copy link
Contributor Author

altro3 commented Nov 12, 2024

Please target 4.9

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validator doesn't throw UnexpectedTypeException in retry
2 participants
@altro3 @dstepanov