Zipkin bad json encoding

[n0tl3ss]

Expected Behavior

Spans to be valid json array

Actual Behaviour

Spans array is not properly json encoded

POST /api/v2/spans HTTP/1.1
host: localhost:9411
Connection: close
content-type: application/json
Content-Length: 284

][{"traceId":"2f1dd400d27b399a","id":"2f1dd400d27b399a","kind":"SERVER","name":"get","timestamp":1686134923454707,"duration":9948,"localEndpoint":{"serviceName":"tracing-test","ipv4":"192.168.205.1"},"tags":{"error":"404","http.method":"GET","http.path":"/","http.status_code":"404"}}

Steps To Reproduce

1. Create application that will use zipking tracing (opentracing)
2. Visit page that doesn't exists (returns 404)
3. Observe zipkin client request body

Environment Information

No response

Example Application

No response

Version

3.9.3

[yawkat]

does it still happen with 4.0?

[graemerocher]

not sure, but a fix needs to be applied to 3.x as well as it impacts teams using 3.x

[yawkat]

ok

[yawkat]

how exactly do i reproduce this? i tried a simple test project and the json was valid:

[graemerocher]

@n0tl3ss can you help @yawkat reproduce

[n0tl3ss]

@yawkat When I put it through proxy I can see that issue exists:

But without proxy spans are somehow correctly sent to zipkin service.

You can also put zipkin url from https://public.requestbin.com/ and you will get something like:

[yawkat]

can you share your example project?

[n0tl3ss]

tracing-demo-json.zip

It is basic project with zipkin from launcher, just change configuration to:

micronaut:
  application:
    name: tracingDemoJson
netty:
  default:
    allocator:
      max-order: 3
tracing:
  zipkin:
    enabled: true
    http:
      url: <url-from-requestbin>
    sampler:
      probability: 1