Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute binders for ServletConfig/ServletContext #708

Merged
merged 4 commits into from
May 27, 2024
Merged

Attribute binders for ServletConfig/ServletContext #708

merged 4 commits into from
May 27, 2024

Conversation

graemerocher
Copy link
Contributor

@graemerocher graemerocher commented May 27, 2024 •
edited
Loading

  • Add attribute binders for ServletConfig/ServletContext
  • Delegate attribute storage to servlet request
  • Add api module to keep engine module mainly runtime API

@graemerocher graemerocher requested a review from yawkat May 27, 2024 12:21
@graemerocher graemerocher added the type: enhancement New feature or request label May 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
79.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher graemerocher merged commit 6a915e7 into 4.8.x May 27, 2024
15 checks passed
@graemerocher graemerocher deleted the more-attributes-binders branch May 27, 2024 13:57
@renovate renovate bot mentioned this pull request Nov 22, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstepanov dstepanov dstepanov approved these changes

@yawkat yawkat Awaiting requested review from yawkat

Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graemerocher @dstepanov