Improvements to the HttpMeterFilterFactory #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added support for specifying service level objectives (allows the creation of apdex widgets). - Added support for specifying the expected max duration. - Added support for specifying the expected min duration. - Added support for histogram directly on the HttpMeterFilterFactory. - Removed the redundant HttpHistogramMeterFilterFactory. - Added tests for validating that the values are set correctly.
graemerocher
added
the
type: improvement
graemerocher
requested changes
May 24, 2024
...core/src/main/java/io/micronaut/configuration/metrics/binder/web/HttpMeterFilterFactory.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/io/micronaut/configuration/metrics/binder/web/config/HttpMeterConfig.java
Show resolved
Hide resolved
...rc/main/java/io/micronaut/configuration/metrics/binder/web/config/HttpServerMeterConfig.java
Show resolved
Hide resolved
...rc/main/java/io/micronaut/configuration/metrics/binder/web/config/HttpClientMeterConfig.java
Show resolved
Hide resolved
graemerocher
approved these changes
May 27, 2024
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #740