Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Skipping Metrics Publishing Based on a Condition #896

Open
hrothwell opened this issue Dec 2, 2024 · 0 comments
Open

Allow Skipping Metrics Publishing Based on a Condition #896

hrothwell opened this issue Dec 2, 2024 · 0 comments

Comments

@hrothwell
Copy link
Contributor

Feature description

Looking for the ability to selectively exclude publishing an @Timed and @Counted metric.

Example use case:

  • a method is tagged with @Timed, this method is called a significant amount of times during processing, enough so that removing the annotation/metrics for this method reduces in the average time to process by 50%.
    • disclaimer: the metric also utilizes AbstractMethodTagger to do additional processing/method tagging. The tagger appends a method name tag using the method invocation context / checks if a class name matches something in particular.
    • In our specific use case we saw avg drop by 500ms, p95 dropped by 1.25s, and p99 dropped by 1s.
  • we still would like to have this method publish metrics in non-prod environments, but turn it off in production for additional performance benefits when applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant