Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify composite #73

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Simplify composite #73

merged 2 commits into from
Mar 3, 2023

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Mar 3, 2023

No description provided.

@sdelamo sdelamo requested a review from timyates March 3, 2023 12:23
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Please check 11e6b80 where I extracted the repeating code to a static package-private method

@sdelamo sdelamo merged commit 085fafe into jooq Mar 3, 2023
@sdelamo sdelamo deleted the simplify-composite branch March 3, 2023 13:22
sdelamo added a commit that referenced this pull request Mar 28, 2023
* use Gradle Kotlin DSL

* Update slsa-framework/slsa-github-generator action to v1.3.0 (#42)

* ci: distribution temurin cla provenance (#44)

* Update stefanzweifel/git-auto-commit-action action to v4.15.4 (#43)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* build: Micronaut Framework 3.7.4

* build: spock 2.2-groovy-3.0

* doc: eager singletons and inject HttpClient (#66)

See micronaut-projects/micronaut-test#716

* ci: projectVersion 1.2.0-SNAPSHOT

* ci: githubCoreBranch 3.9.x

* build: Micronaut Framework 3.8.5

* build: Micronaut Test 3.8.2

* build: Spock 2.3-groovy-3.0

* wip DataSourceResolver

* Convert Delegating datasource and filter non-hikari contents

* Test

* Test to ensure DBCP still works and isn't supported

* Try to downgrade Jooq

* remove @Inject BeanContext ctx

* Simplify composite (#73)

* Simplify composite

* Extract common code to method

---------

Co-authored-by: Tim Yates <[email protected]>

* build: Micronaut Framework 3.8.6

* build: Micronaut Test 3.9.1

* ci: GitHub Actions sync

* [skip ci] Release v1.2.0

* Back to 1.2.1-SNAPSHOT

* Redis support for CRaC (#78)

* wip: Redis support for CRaC

- Currently doesn't work for `@Cacheable` tags
- Needs manual testing with a proper app

* Add base buildSrc plugin

* Add config and tests

* Docs

* Update src/main/docs/guide/resource/redis.adoc

Co-authored-by: Sergio del Amo <[email protected]>

---------

Co-authored-by: Sergio del Amo <[email protected]>

* [skip ci] Release v1.2.1

* Back to 1.2.2-SNAPSHOT

* Fix build with missing dependencies

* Typesafe project accessors

* remove constructor deprecated in 1.2

* Reinstate javadoc

* Update libs.versions.toml

* Update build.gradle.kts

* Update build.gradle.kts

---------

Co-authored-by: Sergio del Amo <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: micronaut-build <[email protected]>
Co-authored-by: micronaut-build <[email protected]>
sdelamo added a commit that referenced this pull request Jun 1, 2023
* use Gradle Kotlin DSL

* Update slsa-framework/slsa-github-generator action to v1.3.0 (#42)

* ci: distribution temurin cla provenance (#44)

* Update stefanzweifel/git-auto-commit-action action to v4.15.4 (#43)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* build: Micronaut Framework 3.7.4

* build: spock 2.2-groovy-3.0

* doc: eager singletons and inject HttpClient (#66)

See micronaut-projects/micronaut-test#716

* ci: projectVersion 1.2.0-SNAPSHOT

* ci: githubCoreBranch 3.9.x

* build: Micronaut Framework 3.8.5

* build: Micronaut Test 3.8.2

* build: Spock 2.3-groovy-3.0

* wip DataSourceResolver

* Convert Delegating datasource and filter non-hikari contents

* Test

* Test to ensure DBCP still works and isn't supported

* Try to downgrade Jooq

* remove @Inject BeanContext ctx

* Simplify composite (#73)

* Simplify composite

* Extract common code to method

---------

Co-authored-by: Tim Yates <[email protected]>

* build: Micronaut Framework 3.8.6

* build: Micronaut Test 3.9.1

* ci: GitHub Actions sync

* [skip ci] Release v1.2.0

* Back to 1.2.1-SNAPSHOT

* Redis support for CRaC (#78)

* wip: Redis support for CRaC

- Currently doesn't work for `@Cacheable` tags
- Needs manual testing with a proper app

* Add base buildSrc plugin

* Add config and tests

* Docs

* Update src/main/docs/guide/resource/redis.adoc

Co-authored-by: Sergio del Amo <[email protected]>

---------

Co-authored-by: Sergio del Amo <[email protected]>

* [skip ci] Release v1.2.1

* Back to 1.2.2-SNAPSHOT

* bug: StatefulRedisPubSubConnection beans are not supported (#91)

* Also destroy StatefulRedisPubSubConnectionResource beans

As raised here #63 (comment)

StatefulRedisPubSubConnection beans were not destroyed during checkpointing, and so we were getting connection closed errors.

* Fix. There are no PubSub beans, they are all connection beans

* Reduce duplication

* Checkstyle...

* Naming

* Visibility

* [skip ci] Release v1.2.2

* Back to 1.2.3-SNAPSHOT

* Handle multiple named Redis servers (#92)

* Handle multiple named Redis servers

* Remove debug

* Fix imports

* Remove deprecated experimental classes and add accepted-api-changes

* [skip ci] Release v1.2.3

* Back to 1.2.4-SNAPSHOT

* Document checkpoint simulator, with java/groovy/kotlin examples (#117)

* Document checkpoint simulator, with java/groovy/kotlin examples

closes #115

* documentation for CheckpointSimulator

* Java/Groovy/Kotlin docs examples

* Extract documented classes to get rid of static

---------

Co-authored-by: Tim Yates <[email protected]>

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: micronaut-build <[email protected]>
Co-authored-by: Tim Yates <[email protected]>
Co-authored-by: micronaut-build <[email protected]>
Co-authored-by: Dean Wette <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants