Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency io.micronaut.data:micronaut-data-bom to v4.0.0-m9 #134

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 11, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.micronaut.data:micronaut-data-bom (source) 4.0.0-M7 -> 4.0.0-M9 age adoption passing confidence

Release Notes

micronaut-projects/micronaut-data

v4.0.0-M8: Micronaut Data 4.0.0-M8

What's Changed

Improvements ⭐
Dependency updates 🚀
Other Changes 💡

New Contributors

Full Changelog: micronaut-projects/micronaut-data@v4.0.0-M7...v4.0.0-M8


Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Jun 11, 2023
@renovate renovate bot force-pushed the renovate/micronaut.data branch from 910eec9 to 70fedf7 Compare June 13, 2023 23:11
@renovate renovate bot changed the title fix(deps): update dependency io.micronaut.data:micronaut-data-bom to v4.0.0-m8 fix(deps): update dependency io.micronaut.data:micronaut-data-bom to v4.0.0-m9 Jun 14, 2023
@timyates
Copy link
Contributor

This is failing as everything was moved around in micronaut-projects/micronaut-data#2189

@renovate
Copy link
Contributor Author

renovate bot commented Jun 19, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

def rows = new Sql(dataSource).rows("select 1")
def rows = new Sql(hikariDataSource).rows("select 1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change we got:

  io.micronaut.data.connection.exceptions.NoConnectionException: No current connection present. Consider declaring @Connectable or @Transactional on the surrounding method

I think it's right... @dstepanov does this look right? Not sure why it started failing with M9

@timyates
Copy link
Contributor

@dstepanov is this c4322d3 the correct fix for the changes to class locations in Data M9?

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dstepanov
Copy link

Yes

@timyates timyates merged commit 090969e into master Jun 19, 2023
@timyates timyates deleted the renovate/micronaut.data branch June 19, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants