Changing Jakarta provide to BeanProvider as it's lazy
#9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawkat
approved these changes
Aug 25, 2023
|
|
||
| /** | ||
| * Default constructor. | ||
| * | ||
| * @param resourceResolver The resource resolver | ||
| */ | ||
| protected HttpConverterRegistrar(Provider<ResourceResolver> resourceResolver) { | ||
| protected HttpConverterRegistrar(BeanProvider<ResourceResolver> resourceResolver) { |
There was a problem hiding this comment.
is this internal? If not need to keep the constructor, deprecate the old one and add @Inject to this one
There was a problem hiding this comment.
Corrected. Those classes should be internal
sdelamo
requested changes
Aug 25, 2023
| /** | ||
| * The constructor. | ||
| * | ||
| * @param resourceResolver The resource resolver |
There was a problem hiding this comment.
it misses @deprecated javadoc
graemerocher
approved these changes
Aug 27, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.