Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement enum constant in kotlin element factory #9774

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Aug 24, 2023

No description provided.

@altro3
Copy link
Contributor Author

altro3 commented Aug 24, 2023

@dstepanov Hi! Could you help with this change? Without it we can't use micronaut-openapi with KSP for enums. But I did something wrong and now I have this exception in test:

изображение

Need help!

@altro3
Copy link
Contributor Author

altro3 commented Aug 24, 2023

@dstepanov Continue #9771 here

@dstepanov
Copy link
Contributor

Please add test

@altro3
Copy link
Contributor Author

altro3 commented Aug 24, 2023

@dstepanov done, but this test works fine.... When I try to use this snapshot inside test project, i have this error:
изображение

@dstepanov
Copy link
Contributor

I will check

@altro3 altro3 marked this pull request as ready for review August 24, 2023 07:09
@altro3
Copy link
Contributor Author

altro3 commented Aug 24, 2023

@dstepanov I figured out what the problem was and fixed it. Now everything works correctly, checked with micronaut-openapi :-)

@sdelamo sdelamo added the lang: kotlin Issues or features specific to Kotlin label Aug 24, 2023
@dstepanov dstepanov added this to the 4.2.0 milestone Aug 24, 2023
@dstepanov
Copy link
Contributor

Thanks!

@dstepanov dstepanov merged commit 2f35acb into micronaut-projects:4.2.x Aug 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: kotlin Issues or features specific to Kotlin
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants