Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BinaryTypeConfiguration #9530

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Add BinaryTypeConfiguration #9530

merged 3 commits into from
Nov 10, 2023

Conversation

timyates
Copy link
Contributor

This is used by the AWS and Azure modules. Originally we moved this duplication to Servlet-core:

micronaut-projects/micronaut-servlet#504

But it was then decided that core was a better home for it.

It specified defaults, and allows users to ignore these defaults, and add their own mime types.

This is used by the AWS and Azure modules.  Originally we moved this duplication to Servlet-core:

micronaut-projects/micronaut-servlet#504

But it was then decided that core was a better home for it.

It specified defaults, and allows users to ignore these defaults, and add their own mime types.
@graemerocher
Copy link
Contributor

but it isn't integrated with the Netty server and client?

@timyates
Copy link
Contributor Author

@graemerocher we ended up with the same thing in Aws and Azure. First, we moved it to servlet-core here micronaut-projects/micronaut-servlet#504 but then it was decided that it should move to core.

But it's not used in netty (server or client)

Finding a home for things is hard ☹️

Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add missing package-info.java file

@sdelamo
Copy link
Contributor

sdelamo commented Jul 1, 2023

@graemerocher and @timyates I think this belongs in micronaut-http it is related with media types. It make sense, we place it in the module where MediaType.java is.

@graemerocher
Copy link
Contributor

I don't think this should be merged if it is not integrated with Netty, it will just be confusing

@sdelamo
Copy link
Contributor

sdelamo commented Jul 4, 2023

I don't think this should be merged if it is not integrated with Netty, it will just be confusing

Do you think we should add it servlet-core or duplicate it across the serverless modules? For me, micronaut-http should serve every http implementation not just netty.

@graemerocher
Copy link
Contributor

if it is specific to server less probably it makes sense in the function module. If you add it to servlet-core then the same question applies, will it be applied to Jetty/Tomcat/Undertow?

@sdelamo
Copy link
Contributor

sdelamo commented Jul 6, 2023

@timyates Please, check if every usage of BinaryTypeConfiguratino is an a module which current depends on io.micronaut:micronaut-function

@timyates
Copy link
Contributor Author

timyates commented Jul 6, 2023

@sdelamo

Azure

Azure does as it has an api dependency on azure-function which has an api dependency on micronaut-function

AWS

And AWS does the same

I'll move this into micronaut-function 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Jul 13, 2023
@sdelamo
Copy link
Contributor

sdelamo commented Aug 3, 2023

@graemerocher can you review this ?

@sdelamo sdelamo changed the base branch from 4.0.x to 4.2.x August 31, 2023 15:08
@sdelamo
Copy link
Contributor

sdelamo commented Aug 31, 2023

ping @graemerocher

@sdelamo sdelamo added this to the 4.2.0 milestone Nov 10, 2023
@sdelamo sdelamo merged commit 0562efa into 4.2.x Nov 10, 2023
@sdelamo sdelamo deleted the binary-config branch November 10, 2023 14:55
@sdelamo
Copy link
Contributor

sdelamo commented Nov 10, 2023

@timyates can you create prs in the different modules to use this API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants