-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BinaryTypeConfiguration #9530
Conversation
This is used by the AWS and Azure modules. Originally we moved this duplication to Servlet-core: micronaut-projects/micronaut-servlet#504 But it was then decided that core was a better home for it. It specified defaults, and allows users to ignore these defaults, and add their own mime types.
but it isn't integrated with the Netty server and client? |
@graemerocher we ended up with the same thing in Aws and Azure. First, we moved it to servlet-core here micronaut-projects/micronaut-servlet#504 but then it was decided that it should move to core. But it's not used in netty (server or client) Finding a home for things is hard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add missing package-info.java file
http/src/main/java/io/micronaut/http/binary/BinaryTypeConfiguration.java
Outdated
Show resolved
Hide resolved
@graemerocher and @timyates I think this belongs in |
I don't think this should be merged if it is not integrated with Netty, it will just be confusing |
Do you think we should add it |
if it is specific to server less probably it makes sense in the |
@timyates Please, check if every usage of BinaryTypeConfiguratino is an a module which current depends on |
AzureAzure does as it has an api dependency on azure-function which has an api dependency on micronaut-function AWSI'll move this into micronaut-function 👍 |
Kudos, SonarCloud Quality Gate passed! |
@graemerocher can you review this ? |
ping @graemerocher |
@timyates can you create prs in the different modules to use this API. |
This is used by the AWS and Azure modules. Originally we moved this duplication to Servlet-core:
micronaut-projects/micronaut-servlet#504
But it was then decided that core was a better home for it.
It specified defaults, and allows users to ignore these defaults, and add their own mime types.