Update MicronautMetaServiceLoaderUtils.java to fix single threaded service loader #11229 #11326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for service loader micronaut-projects#11229 @andriy-dmytruk @graemerocher @dstepanov I believe the change is not complete and still has a logical error. Another way to change the parallelisim would be to set -XX:ActiveProcessorCount. This option is used in dockerized environments to limit resources used by the application. In my tests, wenn I set the option a value smaller than 3 (parallelism is active processor count -1), then micronaut application will not start. I believe the condition to add the services in the class MicronautMetaServiceLoaderUtils (line 260) is not correct: is: if (val != null && predicate != null && !predicate.test(val)) { but should be: if (val != null && !collection.contains(val) && (predicate == null || predicate.test(val))) {
|
|
|
Right, I don't think we need |
| @@ -257,7 +257,7 @@ public List<S> collect(boolean allowFork) { | |||
| List<S> collection = new ArrayList<>(serviceEntries.size()); | |||
| for (String serviceEntry : serviceEntries) { | |||
| S val = instantiate(serviceEntry, classLoader); | |||
| if (val != null && predicate != null && !predicate.test(val)) { | |||
| if (val != null && !collection.contains(val) && (predicate == null || predicate.test(val))) { | |||
There was a problem hiding this comment.
collection.contains(val) might be a costly operation, so I wonder if it is required. Do the services implement a correct equals method, so that this would actually make a difference?
If it is required,can we use a set instead of a list and don't do this check?
There was a problem hiding this comment.
The parallel option has it (line 312)
if (result != null && !values.contains(result)) {
That's why I added it. If the check is not required, I would remove it ... I would prefer to remove it from both places to avoid confusion.
There was a problem hiding this comment.
I think we an remove it there
There was a problem hiding this comment.
okak, I have committed the change
remove collection.contains as it is expensive operation and not needed
dstepanov
approved these changes
Nov 8, 2024
|
Thanks for the contribution! |
PeterFokkinga
pushed a commit
to PeterFokkinga/micronaut-core
that referenced
this pull request
Nov 22, 2024
…rvice loader micronaut-projects#11229 (micronaut-projects#11326) Fix for service loader micronaut-projects#11229 I believe the change is not complete and still has a logical error. Another way to change the parallelisim would be to set -XX:ActiveProcessorCount. This option is used in dockerized environments to limit resources used by the application. In my tests, wenn I set the option a value smaller than 3 (parallelism is active processor count -1), then micronaut application will not start. I believe the condition to add the services in the class MicronautMetaServiceLoaderUtils (line 260) is not correct: is: ``` if (val != null && predicate != null && !predicate.test(val)) { ``` but should be: ``` if (val != null && !collection.contains(val) && (predicate == null || predicate.test(val))) { ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for service loader #11229
@andriy-dmytruk @graemerocher @dstepanov
I believe the change is not complete and still has a logical error. Another way to change the parallelisim would be to set -XX:ActiveProcessorCount. This option is used in dockerized environments to limit resources used by the application.
In my tests, wenn I set the option a value smaller than 3 (parallelism is active processor count -1), then micronaut application will not start.
I believe the condition to add the services in the class MicronautMetaServiceLoaderUtils (line 260) is not correct:
is:
if (val != null && predicate != null && !predicate.test(val)) {
but should be:
if (val != null && !collection.contains(val) && (predicate == null || predicate.test(val))) {