Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip error routes when initial processing of malformed request fails #11161

Merged
merged 1 commit into from
Sep 9, 2024

Commits on Sep 6, 2024

  1. Don't run error routes when initial processing of malformed request f…

    …ails
    
    When netty reports a decode failure, we run the status routes and error response processor. If *that* fails, we would run onError. onError will run filters which can occlude the error because the filters will not see the full headers (decoding failed after all) and may e.g. fail authentication.
    
    This change removes the onError fallback from the decode failure branch.
    yawkat committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9026920 View commit details
    Browse the repository at this point in the history