bug: Writeable responses not being offloaded since 4.0.0 #10723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sdelamo
approved these changes
Apr 17, 2024
timyates
added a commit
that referenced
this pull request
Apr 17, 2024
* Reproducer for Writeable responses not being offloaded * Wrap all writeTo calls in io executor * backported from 4.4.x --------- Co-authored-by: yawkat <[email protected]>
sdelamo
pushed a commit
that referenced
this pull request
Apr 17, 2024
…0729) * Reproducer for Writeable responses not being offloaded * Wrap all writeTo calls in io executor * backported from 4.4.x --------- Co-authored-by: yawkat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation for Writing Response Data we have a section for Writeables which states:
This is true in Micronaut 3.x, but does not happen in certain cases for 4.x
This PR provides a test which passes when added to the 3.10.x branch, but fails on all the current 4.x.x branches
This was discovered whilst investigating fixing views micronaut-projects/micronaut-views#757 as the views were not being delegated to an IO thread pool despite the current documentation there as well