Use Javac's overrides to determine if the method is overridden
#10281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
graemerocher
approved these changes
Dec 18, 2023
Spikhalskiy
reviewed
Dec 18, 2023
| if (!packageName.equals(callingType.getPackageName())) { | ||
| return allowReflection && hasAnnotation(ReflectiveAccess.class); | ||
| } | ||
| if (isPackagePrivate()) { |
There was a problem hiding this comment.
@dstepanov Do we need one more call for isPackagePrivate() here? We just checked it in the if above.
The first part of isPackagePrivate branch looks like a copy of the isProtected branch, so it looks like it could be a refactoring leftover.
There was a problem hiding this comment.
Yeah, I tried to refactor and failed :) I will give it one more chance.
Merged
1 task
This was referenced May 2, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated why we cannot use it by default, there is some limitation to the reflection invocation of the package-private methods. Added it as a note.