Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KSP: use overrides method instead of findOverridee() #10272

Merged
merged 2 commits into from
Dec 15, 2023
Merged

KSP: use overrides method instead of findOverridee() #10272

merged 2 commits into from
Dec 15, 2023

Conversation

dstepanov
Copy link
Contributor

No description provided.

@dstepanov dstepanov added this to the 4.3.0 milestone Dec 15, 2023
@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Dec 15, 2023
@graemerocher
Copy link
Contributor

broken?

@dstepanov
Copy link
Contributor Author

I have deleted all injection private-package tests. Kotlin doesn't have a package-private scope.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 15, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher
Copy link
Contributor

What does this fix?

@dstepanov
Copy link
Contributor Author

Nothing was reported, and two tests got un-pending after this change.
I noticed that this method exists while fixing some other KSP stuff, and I assume it's faster than the previous one.

@dstepanov dstepanov merged commit e3066c4 into 4.3.x Dec 15, 2023
15 checks passed
@dstepanov dstepanov deleted the kspovv branch December 15, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.3.0 Release
Status: Done
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dstepanov @graemerocher