Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch errors on fulfillArguments #10214

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Catch errors on fulfillArguments #10214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions http-server/src/main/java/io/micronaut/http/server/RequestLifecycle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,12 @@ protected FileCustomizableResponseType findFile(HttpRequest<?> request) {
* @return The fulfilled route match, after all necessary data is available
*/
protected ExecutionFlow<RouteMatch<?>> fulfillArguments(RouteMatch<?> routeMatch, HttpRequest<?> request) {
// try to fulfill the argument requirements of the route
routeExecutor.requestArgumentSatisfier.fulfillArgumentRequirementsBeforeFilters(routeMatch, request);
return ExecutionFlow.just(routeMatch);
try {
// try to fulfill the argument requirements of the route
routeExecutor.requestArgumentSatisfier.fulfillArgumentRequirementsBeforeFilters(routeMatch, request);
return ExecutionFlow.just(routeMatch);
} catch (Throwable e) {
return ExecutionFlow.error(e);
}
}
}
Loading