Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document it is possible to use Java Records for immutable configuration with @ConfigurationProperties #10096

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Nov 9, 2023

closes #10086

@wetted
Copy link
Contributor Author

wetted commented Nov 10, 2023

Sergio I am unable to get the generated HTML to render the Java Record snippet for some reason. Investigating...

@timyates
Copy link
Contributor

@wetted running ./gradlew docs -x htmlSanityCheck locally, I see

image

Is that not what you see?

@wetted
Copy link
Contributor Author

wetted commented Nov 10, 2023

@wetted running ./gradlew docs -x htmlSanityCheck locally, I see

image Is that not what you see?

No. Probably a caching issue on my mac. I'll check it again

@wetted
Copy link
Contributor Author

wetted commented Nov 10, 2023

@timyates thanks for checking. It is a cache issue with Chrome on my Mac. I see it just fine with Safari and Firefox, so I'm good with that.

Copy link

sonarcloud bot commented Nov 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit fd9a24c into 4.3.x Nov 13, 2023
16 checks passed
@sdelamo sdelamo deleted the docs-configuration-records branch November 13, 2023 14:30
sdelamo pushed a commit that referenced this pull request Nov 14, 2023
…on with @ConfigurationProperties (#10096)

* Document it is possible to use Java Records for immutable configuration with @ConfigurationProperties

closes #10086

* Change Java record example to snippet, with test.

* Remove statement about @refreshable, pending clarity (and a test).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document it is possible to use Java Records for immutable configuration with @ConfigurationProperties
4 participants