Reduce test pollution with spec.name and requires in http-client tests #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to reduce the flakiness by using Requires and AutoCleanup to try and reduce pollution that may be occuring
timyates
added
the
relates-to: build
|
Kudos, SonarCloud Quality Gate passed!
|
yawkat
reviewed
Nov 8, 2023
| Story story = storyClient.get() | ||
|
|
||
| expect: | ||
| story.storyId == "ABC123" | ||
| story.title == "The Hungry Caterpillar" | ||
| } | ||
|
|
||
| @Issue('https://github.com/micronaut-projects/micronaut-core/issues/6717') |
There was a problem hiding this comment.
this method should stay next to the classes it uses
yawkat
approved these changes
Nov 8, 2023
sdelamo
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to reduce (or remove) the flakiness in PoolTimeoutSpec, I've been through the http-client tests looking for places where we were not using spec.name and Requires.
I've tried to introduce some consistency on how the tests are run, with an embedded server created at field level (shared if multiple tests) and annotated with
@AutoCleanupto ensure it's closed (instead of relying on each spec method to create and close the application)Hopefully closes #9844