Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goaway test #10079

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix goaway test #10079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion http-client/src/test/groovy/io/micronaut/http/client/netty/ConnectionManagerSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,8 @@ class ConnectionManagerSpec extends Specification {
conn1.exchangeSettings()
conn1.testExchangeResponse(future)

conn1.serverChannel.writeOutbound(new DefaultHttp2GoAwayFrame(Http2Error.INTERNAL_ERROR, Unpooled.copiedBuffer("foo", StandardCharsets.UTF_8)))
// use NO_ERROR so that netty doesn't close the channel
conn1.serverChannel.writeOutbound(new DefaultHttp2GoAwayFrame(Http2Error.NO_ERROR, Unpooled.copiedBuffer("foo", StandardCharsets.UTF_8)))
conn1.advance()

// after goaway, new requests should use a new connection
Expand Down