remove DefaultCookieDecoder (#10659)

#10435 remove DefaultCookieDecoder from services because its broken for parsing request cookies

http-netty/src/test/groovy/io/micronaut/http/netty/cookies/NettyLaxClientCookieEncoderSpec.groovy

@@ -2,7 +2,6 @@ package io.micronaut.http.netty.cookies
 
 import io.micronaut.http.cookie.ClientCookieEncoder
 import io.micronaut.http.cookie.Cookie
-
 import spock.lang.Specification
 
 class NettyLaxClientCookieEncoderSpec extends Specification {
@@ -17,4 +16,9 @@ class NettyLaxClientCookieEncoderSpec extends Specification {
         then:
         "SID=31d4d96e407aad42" == cookieEncoder.encode(cookie)
     }
+
+    void "ClientCookieEncoder is NettyLaxClientCookieDecoder"() {
+        expect:
+        ClientCookieEncoder.INSTANCE instanceof NettyLaxClientCookieEncoder
+    }
 }

http-netty/src/test/groovy/io/micronaut/http/netty/cookies/NettyLaxServerCookieDecoderSpec.groovy

@@ -0,0 +1,14 @@
+package io.micronaut.http.netty.cookies
+
+import io.micronaut.core.order.OrderUtil
+import io.micronaut.http.cookie.DefaultServerCookieDecoder
+import io.micronaut.http.cookie.ServerCookieDecoder
+import spock.lang.Specification
+
+class NettyLaxServerCookieDecoderSpec extends Specification {
+
+    void "ServerCookieDecoder is NettyLaxServerCookieDecoder"() {
+        expect:
+        ServerCookieDecoder.INSTANCE instanceof NettyLaxServerCookieDecoder
+    }
+}

http-netty/src/test/groovy/io/micronaut/http/netty/cookies/NettyServerCookieEncoderSpec.groovy

@@ -36,13 +36,19 @@ class NettyServerCookieEncoderSpec extends Specification {
 
         when:
         long maxAge = 2592000
+        cookie = Cookie.of("id", "a3fWa").maxAge(maxAge)
+        String result = cookieEncoder.encode(cookie).get(0)
         String expected = "id=a3fWa; Max-Age=2592000; " + Cookie.ATTRIBUTE_EXPIRES + "=" + expires(maxAge)
         String expected2 = "id=a3fWa; Max-Age=2592000; " + Cookie.ATTRIBUTE_EXPIRES + "=" + expires(maxAge + 1) // To prevent flakiness
-        cookie = Cookie.of("id", "a3fWa").maxAge(maxAge);
-        String result = cookieEncoder.encode(cookie).get(0);
+        String expected3 = "id=a3fWa; Max-Age=2592000; " + Cookie.ATTRIBUTE_EXPIRES + "=" + expires(maxAge - 1) // To prevent flakiness
 
         then:
-        expected == result || expected2 == result
+        expected == result || expected2 == result || expected3 == result
+    }
+
+    void "ServerCookieEncoder is NettyServerCookieEncoder"() {
+        expect:
+        ServerCookieEncoder.INSTANCE instanceof NettyServerCookieEncoder
     }
 
     private static String expires(Long maxAgeSeconds) {

http/src/test/java/io/micronaut/http/cookie/DefaultClientCookieEncoderTest.java

@@ -3,8 +3,14 @@
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
 
 class DefaultClientCookieEncoderTest {
+    @Test
+    void clientCookieEncoderIsDefaultClientCookieEncoder() {
+        assertInstanceOf(DefaultClientCookieEncoder.class, ClientCookieEncoder.INSTANCE);
+    }
+
     @Test
     void clientCookieEncoding() {
         ClientCookieEncoder cookieEncoder = new DefaultClientCookieEncoder();

http/src/test/java/io/micronaut/http/cookie/DefaultServerCookieDecoderTest.java

@@ -7,6 +7,10 @@
 import static org.junit.jupiter.api.Assertions.*;
 
 class DefaultServerCookieDecoderTest {
+    @Test
+    void serverCookieDecoderIsDefaultServerCookieDecoder() {
+        assertInstanceOf(DefaultServerCookieDecoder.class, ServerCookieDecoder.INSTANCE);
+    }
 
     @Test
     void testCookieDecoding() {

http/src/test/java/io/micronaut/http/cookie/DefaultServerCookieEncoderTest.java

@@ -7,8 +7,7 @@
 import java.time.ZonedDateTime;
 import java.time.format.DateTimeFormatter;
 
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.*;
 
 class DefaultServerCookieEncoderTest {
 
@@ -32,6 +31,11 @@ void encodeCookie() {
         assertTrue(expected.equals(result) || expected2.equals(result));
     }
 
+    @Test
+    void serverCookieEncoderIsDefaultServerCookieEncoder() {
+        assertInstanceOf(DefaultServerCookieEncoder.class, ServerCookieEncoder.INSTANCE);
+    }
+
     private static String expires(Long maxAgeSeconds) {
         ZoneId gmtZone = ZoneId.of("GMT");
         LocalDateTime localDateTime = LocalDateTime.now(gmtZone).plusSeconds(maxAgeSeconds);