Fix NPE from SimpleTracer#createBaggage #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was writing a unittest with
SimpleTracer
.Following this baggage API documentation:
This gets NPE while creating a baggage.
It is because in
SimpleBaggageManager
tracing/micrometer-tracing-tests/micrometer-tracing-test/src/main/java/io/micrometer/tracing/test/simple/SimpleBaggageManager.java
Lines 66 to 69 in c93a098
The
this.baggagesByContext.get(traceContext)
returnsnull
. Then trying tostream()
causes NPE.This PR changes to handle the case when
baggagesByContext
map does not have a correspondingtraceContext
.The callers of this method already handle
null
return value.