Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baggage support in Observation #563

Closed
ttddyy opened this issue Jan 30, 2024 · 2 comments
Closed

Baggage support in Observation #563

ttddyy opened this issue Jan 30, 2024 · 2 comments

Comments

@ttddyy
Copy link
Contributor

ttddyy commented Jan 30, 2024

Currently, there is no direct association between Observation and Baggage.
If I want to use baggage, I need to interact with Tracer API. Then, the code needs to mix observation and tracing, which I feel reduces the value of the observation abstraction.

How about tracing-observation-handler to have a list of observation tags that will be converted to baggage?

For example,

Set<String> baggageTags = Set.of("foo.id");
DefaultTracingObservationHandler handler = new DefaultTracingObservationHandler(tracer, baggageTags);
...

When Observation has foo.id tag, it will be treated as baggage.

It would be nice to integrate Observation and Baggage to eliminate the Tracer API usage in user code for baggage.

@ilya40umov
Copy link

ilya40umov commented Feb 15, 2024

I've asked about this topic (Observation's support for Baggage) in #455, so I wonder I this new issue would render my question answered. Wdyt?

@marcingrzejszczak
Copy link
Contributor

duplicate of #455

BTW I really like what @ttddyy suggested. That the fact that a key-value is baggage would become an implementation detail of tracing.

@marcingrzejszczak marcingrzejszczak closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants