Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for #363 #397

Closed
shakuzen opened this issue Oct 10, 2023 · 1 comment · Fixed by #421
Closed

Test for #363 #397

shakuzen opened this issue Oct 10, 2023 · 1 comment · Fixed by #421
Labels
type: task A general task
Milestone

Comments

@shakuzen
Copy link
Member

shakuzen commented Oct 10, 2023

Looking at the commit that resolved this, it doesn't appear there's anything preventing a regression like this from sneaking back in.
As this is quite a fundamental thing, could you ensure it's properly tested?

Originally posted by @vpavic in #363 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants