Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count the JVM GC events that happen before subscribing to notifications #2561

Closed
shakuzen opened this issue Apr 12, 2021 · 1 comment
Closed
Labels
enhancement A general enhancement

Comments

@shakuzen
Copy link
Member

I noticed as part of investigating and testing #2514 that GC events can happen before we subscribe to notifications and those will not be counted. This will result in less GC count/time as well as lower allocated/promoted bytes than actual. We have aggregate information about GCs up until binding in the GarbageCollectorMXBeans. Since that is aggregate info, we can't accurately record it in timer since we lack the individual timings. It would be questionable to record the average time, but I'm not sure it is worse than missing these GC events entirely. Over time, either way becomes inconsequential, but for short-lived applications, the metrics not including events before binding could be significant.

@marcingrzejszczak
Copy link
Contributor

There was no interest in the issue since 2021. We’ll close it for now, and if there still will be any interest, please comment on this issue and we’ll consider re-opening it.

@marcingrzejszczak marcingrzejszczak closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
@jonatan-ivanov jonatan-ivanov removed this from the 1.x milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants