Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly substitute image name when using Microcks native image #20

Closed
lbroudoux opened this issue Mar 28, 2024 · 1 comment
Closed
Assignees
Labels
component/settings Relates to API/settings availables kind/enhancement Enhancement of existing feature
Milestone

Comments

@lbroudoux
Copy link
Member

Reason/Context

When building a MicrocksContainersEnsemble including the async features (withAsyncFeatures()), the async minion container image is automatically deduced from the main container image name. As of today, the microcks-uber part of image is replace by microcks-uber-async-minion, leaving the tag unchanged.

This way of doing things is broker when you use the -native suffix tagged image as there is no microcks-uber-async-minion:nightly-native, for example. Just a microcks-uber-async-minion:nightly.

Description

While we don't have a -native image for async minion, we should also take care of removing the specific -native suffix from image tag.

Implementation ideas

No response

@lbroudoux lbroudoux added the kind/enhancement Enhancement of existing feature label Mar 28, 2024
@lbroudoux lbroudoux self-assigned this Mar 28, 2024
@lbroudoux lbroudoux added the component/settings Relates to API/settings availables label Mar 28, 2024
@lbroudoux lbroudoux added this to the 0.2.3 milestone Mar 28, 2024
@lbroudoux
Copy link
Member Author

Implemented by acd73cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/settings Relates to API/settings availables kind/enhancement Enhancement of existing feature
Projects
None yet
Development

No branches or pull requests

1 participant