Fix for reset/panic overriding the user's stop take 2 #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9d7c834.
It's behaviour now matches how it's used for restart and flash.
✅ Deploy Preview for distracted-dubinsky-fd8a42 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
The delta vs last time is in 556c80b |
|
You can try it out at Test programs on #86. |
microbit-robert
approved these changes
Nov 2, 2022
|
This seems to be working well now. I've asked for some review testing from other Foundation folks so will hold off from merging until I hear back. |
Closed
|
Found #93 reviewing this but it seems to be an unrelated issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A reprise of #88 but without the unfortunate introduction of #90.
Needs careful testing.
Closes #86