Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interrupting input() #103

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Fix interrupting input() #103

merged 1 commit into from
Apr 5, 2023

Conversation

microbit-matt-hillsdon
Copy link
Contributor

@microbit-matt-hillsdon microbit-matt-hillsdon commented Apr 4, 2023

Handle pending KeyboardInterrupt.

Closes #100

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for distracted-dubinsky-fd8a42 ready!

Name Link
🔨 Latest commit 991ed7e
🔍 Latest deploy log https://app.netlify.com/sites/distracted-dubinsky-fd8a42/deploys/642c2ed2ab408f000828c9e3
😎 Deploy Preview https://deploy-preview-103--distracted-dubinsky-fd8a42.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Preview build will be at
https://review-python-simulator.usermbit.org/input-interrupt/

@microbit-matt-hillsdon
Copy link
Contributor Author

This is no good as it breaks interrupting running code.

@dpgeorge
Copy link
Collaborator

dpgeorge commented Apr 4, 2023

Yeah, this is definitely not the right fix!

Handle pending KeyboardInterrupt.

Closes #100
@dpgeorge
Copy link
Collaborator

dpgeorge commented Apr 4, 2023

That looks better.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as ready for review April 5, 2023 08:55
@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 5e619dd into main Apr 5, 2023
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the input-interrupt branch April 5, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset during input() call gives EOFError and further reset/stop attempts fail to return control
2 participants