Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version logged by the REPL #74

Open
microbit-matt-hillsdon opened this issue Sep 27, 2022 · 3 comments
Open

Fix the version logged by the REPL #74

microbit-matt-hillsdon opened this issue Sep 27, 2022 · 3 comments

Comments

@microbit-matt-hillsdon
Copy link
Contributor

microbit-matt-hillsdon commented Sep 27, 2022

Real 2.1.0 prints:

MicroPython v1.18 on 2022-09-26; micro:bit v2.1.0 with nRF52833

Simulator updated to 2.1.0 prints:

MicroPython 61c02c8-dirty on 2022-09-27; micro:bit v2.0.0 with nRF52833

I think the hash there is from the sim repo itself which isn't very helpful (yep, autolinked!). Ideally we'd provide confidence that the sim matched the device.

Ideally the 2.0.0 would be taken from the micropython-microbit-v2 submodule and match it. Potentially we could look at adding a simulator version number too but perhaps not worthwhile.

Not looked into how this is generated yet.

@microbit-matt-hillsdon
Copy link
Contributor Author

@dpgeorge I'd appreciate advice about the MicroPython version header generation. It looks like the code in src/Makefile is generating the correct version information but it's being overwritten by the subsequent MicroPython build. What's the best approach?

@dpgeorge
Copy link
Collaborator

Yeah I can see the problem, it's generating the correct mpversion.h but then that gets overwritten. Not sure exactly how to solve this.

@dpgeorge
Copy link
Collaborator

This PR at upstream MicroPython will hopefully allow us to solve this issue here: micropython/micropython#10044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants