Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biosample slot usage for source_mat_id was not migrated to sheets_and_friends #783

Open
Tracked by #587
turbomam opened this issue Feb 9, 2023 · 3 comments
Open
Tracked by #587
Assignees
Labels
identifiers Tickets associated with identifier updates or needs nmdc-schema-mixs-submission prefix-issues poorly defined, overly general, or misleading prefixes slot usage

Comments

@turbomam
Copy link
Member

turbomam commented Feb 9, 2023

should go in dh_mutliview_common_columns

@turbomam turbomam self-assigned this Feb 9, 2023
@mslarae13
Copy link
Contributor

follow up with @pkalita-lbl that dh_mutliview_common_columns is for all sample types

@mslarae13 mslarae13 mentioned this issue Feb 9, 2023
99 tasks
@turbomam
Copy link
Member Author

turbomam commented Feb 10, 2023

I do see these in sheets-for-nmdc-submission-schema_MLS now. They're also in https://github.com/microbiomedata/sheets_and_friends/blob/issue-163-mixs-subsetter/artifacts/sheets-for-nmdc-submission-schema_MLS-modifications_long.tsv, which I am using in my development of a pure sheets_and_friends approach for managing the relationship between the nmdc-schema and MIxS

slot action target value
source_mat_id add_attribute comments Identifiers must be prefixed. Possible FAIR prefixes are IGSNs (http://www.geosamples.org/getigsn), NCBI biosample accession numbers, ARK identifiers (https://arks.org/). These IDs enable linking to derived analytes and subsamples. If you have not assigned FAIR identifiers to your samples, you can generate UUIDs (https://www.uuidgenerator.net/).
source_mat_id replace_attribute description A globally unique identifier assigned to the biological sample.
source_mat_id overwrite_examples examples IGSN:AU1243|UUID:24f1467a-40f4-11ed-b878-0242ac120002
source_mat_id replace_attribute identifier true
source_mat_id add_attribute notes The source material IS the Globally Unique ID
source_mat_id replace_attribute required true
source_mat_id replace_attribute string_serialization {text}:{text}
source_mat_id replace_attribute title source material identifier
source_mat_id add_attribute todos Currently, the comments say to use UUIDs. However, if we implement assigning NMDC identifiers with the minter we don't need to require a GUID. It can be an optional field to fill out only if they already have a resolvable ID.

I can't really remember where we didn't see them so I'm leaving this issue open.

I had been extracting Biosample's MIxS slot usages with nmdc_schema/get_class_usages.py in the nmdc-schema repo.

@turbomam
Copy link
Member Author

follow up with @pkalita-lbl that dh_mutliview_common_columns is for all sample types

I don't think we have defined "sample types", but here is my understanding of dh_mutliview_common_columns. Notably, the integration with Data Portal interfaces/templates is manually configured with dh_interfaces tab.

  • dh_mutliview_common_columns is defined as a mixable class on the mixins tab
  • dh_interface subclasses are defined on the dh_interfaces tab, and the dh_mutliview_common_columns mixin is associated with each.
  • import_slots_regardless is used to associate slots from the nmdc-schema with any class, including dh_mutliview_common_columns
  • likewise, modifications_long applies modifications to slots in any class, including dh_mutliview_common_columns

@turbomam turbomam added nmdc-schema-mixs-submission identifiers Tickets associated with identifier updates or needs slot usage labels Feb 16, 2023
@turbomam turbomam added the prefix-issues poorly defined, overly general, or misleading prefixes label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
identifiers Tickets associated with identifier updates or needs nmdc-schema-mixs-submission prefix-issues poorly defined, overly general, or misleading prefixes slot usage
Projects
None yet
Development

No branches or pull requests

2 participants