Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depth should be required for relevant sample types, like soil #612

Closed
5 tasks
mslarae13 opened this issue Jan 18, 2023 · 2 comments
Closed
5 tasks

depth should be required for relevant sample types, like soil #612

mslarae13 opened this issue Jan 18, 2023 · 2 comments

Comments

@mslarae13
Copy link
Contributor

depth should not be required for all biosamples.

NMDC schema should

  • Split out subclasses for different sample types (soil, plant, water)
  • slots should be identified as required or recommended based on sample type

Criteria for completion

  • Schema classes updated
  • schema slots updated
  • slot updates are present in submission portal
@mslarae13 mslarae13 changed the title depth should only be required for relevant soil types depth should be required for relevant sample types, like soil Jan 18, 2023
@mslarae13
Copy link
Contributor Author

mslarae13 commented Sep 8, 2023

In relation, depth is currently listed an required for host-associated in the submission schema.
Is depth in host-associated required in the schema?
Need to make depth NOT required for host-associated in submission schema.

@mslarae13
Copy link
Contributor Author

microbiomedata/submission-schema#150 closes this. The separation of requirement level is managed in the submission schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants