Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id and samp_name should both be unique keys for Biosamples #588

Open
Tracked by #587
turbomam opened this issue Jan 6, 2023 · 2 comments
Open
Tracked by #587

id and samp_name should both be unique keys for Biosamples #588

turbomam opened this issue Jan 6, 2023 · 2 comments
Assignees
@turbomam

Comments

@turbomam
Copy link
Member

turbomam commented Jan 6, 2023

No description provided.

@turbomam turbomam self-assigned this Jan 6, 2023
@turbomam turbomam mentioned this issue Jan 6, 2023
Closed
@turbomam
Copy link
Member Author

turbomam commented Jan 6, 2023

  • add unique key constrains to schema.
    • how to keep a in-schema "self-docuemtantion" that isn't excessively visible to end users?
      • separate document
      • YAML # comments
      • less visible notes
  • ensure that there are good positive and negative examples
  • switch from nmdc-specific check -jsonschema validation to linkml-run-examples

@mslarae13
Copy link
Contributor

Duplicates #581

@mslarae13 mslarae13 mentioned this issue Jan 18, 2023
Open
99 tasks
turbomam added a commit that referenced this issue Jan 27, 2023
@turbomam
#588 Biosample unique keys only
2db2eeb 
see also #589, but that may only have poetry config changes
@turbomam turbomam mentioned this issue Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbomam turbomam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turbomam @mslarae13