Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stray omics_type slot #250

Closed
Tracked by #587
wdduncan opened this issue Jan 27, 2022 · 2 comments
Closed
Tracked by #587

remove stray omics_type slot #250

wdduncan opened this issue Jan 27, 2022 · 2 comments
Assignees
Labels
type type as a slot

Comments

@wdduncan
Copy link
Contributor

In nmdc.yaml, there seems to be a stay omics_type slot that is not associated with any class:

 omics_type:
    range: string

This is not that same of the omics type slot that is used for omics processing:

omics type:
    range: controlled term value 
    description: >-
      The type of omics data
    examples:
      - value: metatranscriptome
      - value: metagenome

cc @turbomam @sujaypatil96 @cmungall @dehays

@wdduncan wdduncan self-assigned this Jan 27, 2022
@mslarae13 mslarae13 mentioned this issue Jan 18, 2023
99 tasks
@turbomam turbomam added the type type as a slot label Feb 16, 2023
@brynnz22
Copy link
Contributor

@turbomam can this be marked as closed and finished? I looked at the nmdc.yaml file and all I see is omics_type. I do not see any such omics type slot described above?

@turbomam
Copy link
Member

Yes, thank you!

turbomam pushed a commit that referenced this issue Oct 7, 2024
Add migrator to check and add `type` slot to `Protocol` records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type type as a slot
Projects
None yet
Development

No branches or pull requests

3 participants